Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate maintaners url #52 #57

Closed

Conversation

amireshoon
Copy link

Update validate script so that it also checks URLs for maintainers and fails the CI check. And some changes in code for avoiding code repetition and resolves #52

@amireshoon
Copy link
Author

amireshoon commented Jun 27, 2021

in case of merging this pr please ignore #56

@mehdy
Copy link
Member

mehdy commented Jul 1, 2021

It's great that have resolved one of the issues as well.
To make the PR review easier and better, just make this PR about solving the issue (since you've already opened another PR for adding your repos)

@amireshoon
Copy link
Author

Thank you for your attention. I will open another PR including just issue #52

@amireshoon amireshoon closed this Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check Maintainers Name in Repo File
2 participants