Remove default pinpoint config #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A default_init_pinpoint will be problematic when switching trees. Whilst we can change the config setting, ideally this is a per-tree setting which we can revisit if/when we have an organised home for such things (e.g. tree_startpoints table). Duck the problem for now, hard-code the default to @_ozid=1, which is always the root.
The pzoom animation for @biota doesn't make much sense, as you're just zooming into a static image. As a special case, zoom in first and pzoom out for the root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided having an extra tree-dependent config option wasn't worth the heart-ache, so removing.
Mitigate my concerns about pzoom to @biota by pzooming out, as a special case.
Fixes #742