Issue 781 markdown in tours #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't have anything useful to say, we should just keep quiet.
The window_text class got lost at some point, put it back in.
Run all window_text through web2py's bundled markdown parser, wrapping the instantiation so we can enable safe_mode. This will mean all window_text content will be wrapped in <p>s, remove the final margin to preserve previous spacing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put tour window_text content through web2py's bundled markdown parser.
Enable
safe_mode, so we at least don't allow raw HTML, but we will want to revisit this before allowing user generated content, as links (e.g.) would still be possible.Fixes #781