-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12/10/2022]: Backend API [feat] - Project structure #14
[12/10/2022]: Backend API [feat] - Project structure #14
Conversation
Thank you @RealRichi3 for your hard work! Just to double-check, I just merged PR #14 for dev branch. Would you like to have your work at the same dev branch or I can create another one if you are working in different groups? |
Thanks @BatoolMM, i would be better to work on a different branch, but we were hoping to discuss more on that tomorrow |
I created a new branch called |
Perfect, but will the zoom session for tomorrow still hold? |
Hi @RealRichi3, I am very sorry that this will be postponed till Tuesday at the same time. This was outside our control, but we are happy to support you and answer questions you have. I think the best way to resolve this PR is to create another one directed toward a dev_team2 branch. Let us know if you want to proceed using a different approach, @alswajiab and I will help you with it 🌻 |
Apologies, it was closed by mistake, it is re-opened now! |
Alright, i guess we'll go with it. The issue i had was that, since the project plan has been set in issue #5, every pull request to the branch has to be reviewed so it'll be inline with the project plan, i'd like to suggest that i should review all pull request made to |
Another idea. Since the backend and frontend are part of the main plan in issue #2, we can just use one branch, then two separate folders in it, the front end work will be done in the For this proposal @sandyguide can review all PR related to the frontend issue #10 Once reviewed we can just comment |
I love the way you have been managing and organising the protject @RealRichi3. I created a new tag |
@RealRichi3 just to be sure, are we using the |
@sandygudie let's go for the |
Thanks @BatoolMM, i Will make the PR to |
Alright then, i will set up a frontend structure for |
Sorry it's |
@BatoolMM is there a way to direct this particular PR to |
@sandygudie it's |
@BatoolMM it's ready to merge to |
@BatoolMM how do we add the |
Brilliant, it's merged now! |
@RealRichi3 , let me know if you still can't access |
…chi3/backend/dev [12/10/2022]: Backend API (feat) - Project structure
Summary
Setup NodeJS MVC app structure for the BACKEND API for MOOCs platform issue #5
Fixes issue #13
List of changes proposed in this PR (pull-request)
What should a reviewer concentrate their feedback on?