-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create and Add both history page and settings page #63
base: dev_team2
Are you sure you want to change the base?
Create and Add both history page and settings page #63
Conversation
Can you add more description to the PR, you modified 16 files in this PR, but there is little added in the description/summary of the PR. Documentation is very important when we de-bug in the future and for the continuity of the open-source project. |
@Teslimsama, Also, I suggest you add screenshots of how the developed pages look. |
@Teslimsama Just incase you did not know , we are only using Plain CSS |
how do i go a bout it i can't find where to upload pictures @Meekunn |
@Teslimsama, a drag and drop should do... |
@BatoolMM am done anything else |
@Teslimsama please can you separate the tasks you working on, implementing two tasks on one PR can be a bit difficult to debug in the future, also for separation of concerns |
@Teslimsama There are way too many changes. And we decided to only use plain CSS |
@BatoolMM is there anything else |
@okerekechinweotito what do you mean |
Thank you @Teslimsama for your wonderful work. As @sandygudie and @okerekechinweotito mentioned, you are addressing multiple things/tasks in a single PR. Can you break down this PR to multiple PR, please? |
This comment was marked as off-topic.
This comment was marked as off-topic.
@sandygudie how do I go about it
|
Summary
Fixes #18
description
i created the front-end design for the history and settings pages
What should a reviewer concentrate their feedback on?