Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and Add both history page and settings page #63

Open
wants to merge 2 commits into
base: dev_team2
Choose a base branch
from

Conversation

Teslimsama
Copy link

@Teslimsama Teslimsama commented Oct 19, 2022

Summary

Fixes #18

description

i created the front-end design for the history and settings pages

  • added front end design of history page
  • added front end design of settings page
  • added my own edited bootstrap css file
  • added my own edited bootstrap JavaScript file
  • added two style.css files ,one for the navbar and the other for the settings page list
  • added an image in the img file
  • added a jQuery file
  • added a toggle on the settings page list

What should a reviewer concentrate their feedback on?

@Teslimsama Teslimsama changed the base branch from main to dev_team2 October 19, 2022 16:30
@Teslimsama Teslimsama changed the title making some changes to history page Create and Add both history page and settings page Oct 19, 2022
@BatoolMM
Copy link
Member

Can you add more description to the PR, you modified 16 files in this PR, but there is little added in the description/summary of the PR. Documentation is very important when we de-bug in the future and for the continuity of the open-source project.

@Meekunn
Copy link
Contributor

Meekunn commented Oct 20, 2022

@Teslimsama, Also, I suggest you add screenshots of how the developed pages look.

@okerekechinweotito
Copy link
Contributor

@Teslimsama Just incase you did not know , we are only using Plain CSS

@Teslimsama
Copy link
Author

@Teslimsama, Also, I suggest you add screenshots of how the developed pages look.

how do i go a bout it i can't find where to upload pictures @Meekunn

@Meekunn
Copy link
Contributor

Meekunn commented Oct 21, 2022

@Teslimsama, a drag and drop should do...

@Teslimsama
Copy link
Author

Screenshot 2022-10-21 112546
Screenshot 2022-10-21 112802
Screenshot 2022-10-21 112900
Screenshot 2022-10-21 113052
Screenshot 2022-10-21 113143
Screenshot 2022-10-21 113245
Screenshot 2022-10-21 113354
Screenshot 2022-10-21 112441

@Teslimsama
Copy link
Author

Teslimsama commented Oct 21, 2022

@BatoolMM am done anything else

@sandygudie
Copy link
Member

sandygudie commented Oct 21, 2022

@Teslimsama please can you separate the tasks you working on, implementing two tasks on one PR can be a bit difficult to debug in the future, also for separation of concerns

@okerekechinweotito
Copy link
Contributor

@Teslimsama There are way too many changes. And we decided to only use plain CSS

@Teslimsama
Copy link
Author

@BatoolMM is there anything else

@Teslimsama
Copy link
Author

@okerekechinweotito what do you mean

@BatoolMM
Copy link
Member

Thank you @Teslimsama for your wonderful work. As @sandygudie and @okerekechinweotito mentioned, you are addressing multiple things/tasks in a single PR. Can you break down this PR to multiple PR, please?

@Teslimsama

This comment was marked as off-topic.

@Teslimsama
Copy link
Author

@sandygudie how do I go about it

@Teslimsama please can you separate the tasks you working on, implementing two tasks on one PR can be a bit difficult to debug in the future, also for separation of concerns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants