Feature: handle quick contact form with formspree.io - index.html, ar… #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oscksa ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@BatoolMM Please review |
BatoolMM
approved these changes
Oct 21, 2022
|
Thank you, it's working (email is delivered) but still shows an error in the website, not sure why! I will merge this for now as quick fix! |
|
@all-contributors please add @RealRichi3 for infra |
|
I've put up a pull request to add @RealRichi3! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Quick contact form for homepage returns error 405 - issue #129
Email handler for quick contact form exposes sensitive private keys in front end - issue #130
For this fix, an account should be created on formspree.io to get the form_id to the passed in the form action url (line 522 for index.html, line 481 for ar-index.html)
Fixes #129 #130 #146
Lorem ipsum dolor sit amet, consectetur adipiscing.
List of changes proposed in this PR (pull-request)
What should a reviewer concentrate their feedback on?