Use SyftException

OpenMined · Aug 27, 2024 · 2848e38 · 2848e38
1 parent b254e99
commit 2848e38
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/syft/src/syft/service/project/project.py b/packages/syft/src/syft/service/project/project.py
@@ -1236,7 +1236,7 @@ def start(self, return_all_projects: bool = False) -> Project | list[Project]:
 
     def send(self, return_all_projects: bool = False) -> Project | list[Project]:
         if len(self.clients) == 0:
-            return SyftError(message=_EMPTY_MEMBER_LIST_ERROR_MESSAGE)
+            raise SyftException(public_message=_EMPTY_MEMBER_LIST_ERROR_MESSAGE)
 
         # Currently we are assuming that the first member is the leader
         # This would be changed in our future leaderless approach

diff --git a/packages/syft/tests/syft/project/project_test.py b/packages/syft/tests/syft/project/project_test.py
@@ -6,7 +6,7 @@
 import syft as sy
 from syft.service.project.project import Project
 from syft.service.project.project import _EMPTY_MEMBER_LIST_ERROR_MESSAGE
-from syft.service.response import SyftError
+from syft.types.errors import SyftException
 
 
 def test_project_creation(worker):
@@ -119,6 +119,6 @@ def test_submit_project_with_empty_member_list_error() -> None:
         name="My Cool Project", description="My Cool Description", members=[]
     )
 
-    res = new_project.send()
-    assert isinstance(res, SyftError)
-    assert _EMPTY_MEMBER_LIST_ERROR_MESSAGE in res.message
+    with pytest.raises(SyftException) as exc:
+        new_project.send()
+    assert _EMPTY_MEMBER_LIST_ERROR_MESSAGE in exc.value.public_message