-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove infection from yii app example #479
base: 0.6
Are you sure you want to change the base?
Remove infection from yii app example #479
Conversation
Co-authored-by: Viktor Szépe <[email protected]>
c0fb851
to
5d2cded
Compare
@vjik looks like there is another PHP 8.4 issue in Yii:
yiisoft/yii-console#218 not sure if there are other places like this |
It's not clear yet — wait for Psalm 6 release (there is hope) or switch to PHPStan. |
@yjik Do you know if there is a |
I think we will release it today or tomorrow. |
PHP 8.4 is not yet supported in infection plugin by @Roave as we found out in #478 @szepeviktor.
So we will remove the unneeded infection part of the example to make the CI green again.
Else I tried where possible to update the composer.json to match current state of https://github.com/yiisoft/app with changes by @vjik and the yii team.