Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove infection from yii app example #479

Open
wants to merge 2 commits into
base: 0.6
Choose a base branch
from

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Jan 20, 2025

PHP 8.4 is not yet supported in infection plugin by @Roave as we found out in #478 @szepeviktor.

So we will remove the unneeded infection part of the example to make the CI green again.

Else I tried where possible to update the composer.json to match current state of https://github.com/yiisoft/app with changes by @vjik and the yii team.

@alexander-schranz alexander-schranz force-pushed the enhancement/yii-remove-infection-integration branch from c0fb851 to 5d2cded Compare January 20, 2025 17:12
@alexander-schranz alexander-schranz added bug Something isn't working Integration: Yii Yii related issue labels Jan 20, 2025
@alexander-schranz alexander-schranz marked this pull request as ready for review January 20, 2025 17:16
@alexander-schranz
Copy link
Member Author

alexander-schranz commented Jan 21, 2025

@vjik looks like there is another PHP 8.4 issue in Yii:

 PHP Fatal error:  Uncaught ErrorException: Yiisoft\Yii\Console\Application::extractNamespace(): Implicitly marking parameter $limit as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/search/search/.examples/yii/vendor/yiisoft/yii-console/src/Application.php:90
Stack trace:
#0 /home/runner/work/search/search/.examples/yii/vendor/composer/ClassLoader.php(576): Yiisoft\Config\Config::{closure:{closure:Yiisoft\Config\Config::buildFile():158}:160}()
#1 /home/runner/work/search/search/.examples/yii/vendor/composer/ClassLoader.php(576): include()
#2 /home/runner/work/search/search/.examples/yii/vendor/composer/ClassLoader.php(427): {closure:Composer\Autoload\ClassLoader::initializeIncludeClosure():575}()
#3 /home/runner/work/search/search/.examples/yii/vendor/yiisoft/yii-console/config/params-console.php(11): Composer\Autoload\ClassLoader->loadClass()
#4 /home/runner/work/search/search/.examples/yii/vendor/yiisoft/config/src/Config.php(171): require('...')
#5 /home/runner/work/search/search/.examples/yii/vendor/yiisoft/config/src/Config.php(184): Yiisoft\Config\Config::{closure:Yiisoft\Config\Config::buildFile():158}()
#6 /home/runner/work/search/search/.examples/yii/vendor/yiisoft/config/src/Config.php(114): Yiisoft\Config\Config->buildFile()
#7 /home/runner/work/search/search/.examples/yii/vendor/yiisoft/config/src/Config.php(92): Yiisoft\Config\Config->buildGroup()
#8 /home/runner/work/search/search/.examples/yii/vendor/yiisoft/config/src/Config.php(72): Yiisoft\Config\Config->runBuildParams()
#9 /home/runner/work/search/search/.examples/yii/vendor/yiisoft/yii-runner/src/ApplicationRunner.php(156): Yiisoft\Config\Config->get()
#10 /home/runner/work/search/search/.examples/yii/vendor/yiisoft/yii-runner/src/ApplicationRunner.php(107): Yiisoft\Yii\Runner\ApplicationRunner->getConfiguration()
#11 /home/runner/work/search/search/.examples/yii/vendor/yiisoft/yii-runner-console/src/ConsoleApplicationRunner.php(100): Yiisoft\Yii\Runner\ApplicationRunner->runBootstrap()
#12 /home/runner/work/search/search/.examples/yii/yii(17): Yiisoft\Yii\Runner\Console\ConsoleApplicationRunner->run()
#13 {main}
  thrown in /home/runner/work/search/search/.examples/yii/vendor/yiisoft/yii-console/src/Application.php on line 90

yiisoft/yii-console#218 not sure if there are other places like this

@vjik
Copy link
Contributor

vjik commented Jan 23, 2025

vimeo/psalm and roave/infection-static-analysis-plugin (not infection/infection) prevent running tests on PHP 8.4.

It's not clear yet — wait for Psalm 6 release (there is hope) or switch to PHPStan.

@alexander-schranz
Copy link
Member Author

@yjik Do you know if there is a Yii\Console released planned with the PHP 8.4 deprecation fixes in the next times?

@vjik
Copy link
Contributor

vjik commented Jan 23, 2025

@yjik Do you know if there is a Yii\Console released planned with the PHP 8.4 deprecation fixes in the next times?

I think we will release it today or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration: Yii Yii related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants