feat: add ERC721 token standard #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build: add "forge-std" and "prb-math" as git submodules build: keep only the essential Node.Js dependencies chore: add more explanatory comments in contract implementations chore: add more rules in ".solhint.json" chore: add "remappings.txt" file chore: delete Hardhat and its Node.Js paraphernalia chore: delete TypeScript bindings chore: update ignore config files chore: update ".env" and ".env.example" ci: update github workflow to run Foundry docs: update README to document Foundry instead of Hardhat switch to Foundry refactor: "addedAmount" to just "amount"" refactor: "amount" to "value" in all approve-related functions refactor: "burnAmount" to just "amount" refactor: change "nonRecoverableTokens" to "tokenDenylist" refactor: delete the "_" prefix from admin functions refactor: import from "@prb/math" instead of "@prb/math/contracts" refactor: "mintAmount" to just "amount" refactor: move "contracts" to "src" refactor: "NonStandardERC20" to "NonCompliantERC20" refactor: perform approval before transfer in "transferFrom" refactor: "recoverAmount" to just "amount" refactor: rename custom errors refactor: "subtractedAmount" to just "amount"" test: add testing trees test: switch all tests to be run with Forge
build: delete "*/*.sol" glob from "files" field in "package.json"
test: delete MAX_UINT_256
docs: change title to "PRBContracts" in README docs: capitalize labels in badges
build: update git submodules test: ERC721 contract
test: approve event when caller is not the owner test: burn more precisely
andreivladbrg
force-pushed
the
feat/erc721
branch
2 times, most recently
from
8c84065 to
ccc04e6
Compare
refactor: add underscore to the internal mapping names build: "forge config --fix"
chore: add explanatory comments
|
Due to too many git conflicts I'm closing this PR in favor of #34. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #32.