Build improvement and update french translation #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix locale dir on custom install prefix
Philip-Scott
requested changes
Mar 24, 2022
There was a problem hiding this comment.
Hey, thank you for your contribution, I really appreciate it! :) I left out some comments inline, but my main concern is about the executable name which is a requirement for publishing elementary OS apps.
For future changes to this or any other open-source project, I would recommend making pull request only do one thing :) That way it can keep pull requests small and more review friendly, and one change wouldn't depend on the other from going in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some change to allow users to install Notes-up in a custom prefix without losing translations (currently, translations were only found in
/usr/share/localedirectory).Also, I think it's not absolutely necessary to use an app id as the app name, so I created an app id separately in the build system.
Finally, I updated french translations.