SOLPS2IMAS dependecy removed #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GGDUtils is now only dependent on OMAS.jl. For testing, a json file has been created with SOLPS2IMAS and now is used instead of the original SOLPS files. This removed the test dependency on SOLPS2IMAS. I also cleared all old sample files from the repository. The test script was also modified to load the ids structure only once and use for all tests and print out individual time for each large function.
anchal-physics
added a commit
to ProjectTorreyPines/SOLPS2imas.jl
that referenced
this pull request
Nov 7, 2023
Since all subset tools have been moved to GGDUtils ProjectTorreyPines/IMASggd.jl#25 and GGDUtils has been made independent of SOLPS2IMAS ProjectTorreyPines/IMASggd.jl#26 now we can make SOLPS2IMAS dependent on GGDUtils. For this, all subset tool functions have been deleted. The test script was also modified to conform with same style of testing as other packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GGDUtils is now only dependent on OMAS.jl. For testing, a json file has been created with SOLPS2IMAS and now is used instead of the original SOLPS files. This removed the test dependency on SOLPS2IMAS.
I also cleared all old sample files from the repository. The test script was also modified to load the ids structure only once and use for all tests and print out individual time for each large function.