Releasing v.0.2.1 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected hard-coded dimension use and comments.
Following new functions are being added to the subset_tools.jl file: - add_subset_element! - get_subset_space - get_grid_subset_with_index - get_subset_boundary_inds - get_subset_boundary - subset_do These functions have been modified to have fixed input argument types. Currently, most grid_subset operations are only defined for edge profiles but this can be expanded easily using get_types_with() from types.jl. This removes all dependence of GGDUtils from SOLPS2IMAS except for the test script. This will be removed in a later commit.
Moving grid_subset functions from SOLPS2IMAS
GGDUtils is now only dependent on OMAS.jl. For testing, a json file has been created with SOLPS2IMAS and now is used instead of the original SOLPS files. This removed the test dependency on SOLPS2IMAS. I also cleared all old sample files from the repository. The test script was also modified to load the ids structure only once and use for all tests and print out individual time for each large function.
SOLPS2IMAS dependecy removed. Simple PR, so merging without review.
Plot recipes also used dimension information to determine how to plot subsets of different dimensions. This got left out in the dimension updte PR earlier in #24
Updating dimension use in recipes
* Using subset tools from GGDUtils.jl now * Marking examples/Project.toml to be ignored by git * Using develop to add latest GGDUtils.jl in plotting tests
Updated plotting examples to reflect new changes
Added recipe to plot interferometer geometry on top of SOLPS mesh in the R-Z plane. Added recipes for plotting integrated and averaged electron density data from interferometer as time series. Added example file to see how to use these functions.
Plotting recipes for interferometer data
Some simple: - Remove unnecessary array allocation - Improve performance of _G function Some complicated - Avoid returning multiple function calls - Use let function to avoid captured variables (see https://docs.julialang.org/en/v1/manual/performance-tips/#man-performance-captured)
Optimization changes
eldond
reviewed
Jan 18, 2024
eldond
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
The other notebook, plotting.ipynb, executes.
I guess this version of plotting_interferometer.ipynb is different since it runs out of a sample file that has all the interferometer data loaded, right? Redundancy/overlap in examples should be okay in principle, as long as there isn't huge code duplication. So this should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes