Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile clones without .jl in .julia/dev and more #38

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

anchal-physics
Copy link
Collaborator

make r option now checks if it is called from inside a repo that is present in .julia/dev and if present there, it clones the dependent repos without the .jl extension.

It also runs dvc pull to ensure sample files have been pulled

This fixes ProjectTorreyPines/SOLPS2ctrl.jl#43

make r option now checks if it is called from inside a repo that is
present in .julia/dev and if present there, it clones the dependent
repos without the .jl extension.

It also runs dvc pull to ensure sample files have been pulled
@anchal-physics anchal-physics requested a review from eldond March 9, 2024 02:38
Copy link
Contributor

@eldond eldond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks reasonable, but I feel like I would need to tear up my local installation to properly test this. Should we set up a jenkins job to test environment setup?

@anchal-physics anchal-physics merged commit d09fa22 into dev Mar 11, 2024
1 check passed
@eldond eldond deleted the make branch March 11, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants