Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep vowels in generated prefixes #287 #289

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

lalewis1
Copy link
Collaborator

keep vowels but remove all punctuation characters as per #287

keep vowels but remove all punctuation characters as per #287
@lalewis1 lalewis1 marked this pull request as draft October 25, 2024 00:02
to conform to new prefix generation logic
@lalewis1 lalewis1 marked this pull request as ready for review October 25, 2024 00:48
Copy link
Collaborator

@recalcitrantsupplant recalcitrantsupplant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks

@recalcitrantsupplant recalcitrantsupplant merged commit 541230b into main Oct 25, 2024
1 check passed
@recalcitrantsupplant recalcitrantsupplant deleted the lawson/prefixes branch October 25, 2024 03:42
Copy link

🎉 This PR is included in version 4.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants