Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions CI Port #16082

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

illusion0001
Copy link
Contributor

@illusion0001 illusion0001 commented Sep 15, 2024

Cache is supported on the penguin
Cold: https://github.com/illusion0001/rpcs3/actions/runs/10871089443/attempts/1
Warm: https://github.com/illusion0001/rpcs3/actions/runs/10871089443

Plans for later, build in clang and gcc on Windows and OSX

@Megamouse Megamouse added the Build and CI Anything related to the build process and continuous integration label Sep 19, 2024
@illusion0001 illusion0001 marked this pull request as draft September 23, 2024 10:17
@hcorion
Copy link
Member

hcorion commented Sep 23, 2024

What's the motivation for porting to GitHub Actions? Doesn't it have the exact same restrictions as Azure?

@illusion0001 illusion0001 force-pushed the patch-1 branch 3 times, most recently from 1cdde6d to 1b3a7cd Compare September 28, 2024 08:52
@illusion0001
Copy link
Contributor Author

illusion0001 commented Sep 28, 2024

What's the motivation for porting to GitHub Actions? Doesn't it have the exact same restrictions as Azure?

so users don't have to sign up to extra services to run auto builds, and yeah i think

@q4a
Copy link
Contributor

q4a commented Jan 19, 2025

What's the motivation for porting to GitHub Actions? Doesn't it have the exact same restrictions as Azure?

I think that GitHub Actions is useful now because of free arm64 runners. I improved illusion0001's version a bit:
https://github.com/q4a/rpcs3/commits/arm-ci/
But don't understand how to pass $COMPILER env to docker?
Check fail on github actions:
https://github.com/q4a/rpcs3/actions/runs/12852962562/job/35835578225
vs sucess on Cirrus CI:
https://cirrus-ci.com/task/6366890357948416

@illusion0001
Copy link
Contributor Author

$COMPILER is used to distinguish between GCC and clang builds

@q4a
Copy link
Contributor

q4a commented Jan 19, 2025

But don't understand how to pass $COMPILER env to docker?

I know that)
Cirrus CI has this lines in log:
https://cirrus-ci.com/task/6366890357948416

+ export CC=clang-18
+ export CXX=clang++-18

Actions x86_64 has this lines in log:
https://github.com/q4a/rpcs3/actions/runs/12852962562/job/35835578464

+ export CC=clang-18
+ export CXX=clang++-18

But Actions arm64 has only this lines in log:
https://github.com/q4a/rpcs3/actions/runs/12852962562/job/35835578225

+ export CC=
+ export CXX=

@q4a
Copy link
Contributor

q4a commented Jan 19, 2025

Ok. I fixed arm64 build with simple chmod +x ‎.ci/build-linux-aarch64.sh.
@illusion0001 can you cherry-pick or just copy my changes to this PR?
https://github.com/q4a/rpcs3/commits/arm-ci/
Here is build result:
https://github.com/q4a/rpcs3/actions/runs/12853858021

@Darkhost1999
Copy link
Contributor

Darkhost1999 commented Jan 19, 2025

Screenshot.jpg

Maybe instead of matrix: Linux Build it can be matrix: Linux Aarch 64 and matrix: Linux X64 by creating new name categories.
I was looking into splitting the files and then just using uses ./.workflows/linux_aarch64.yml
That way there's a main file for rpcs3.yml and then maintainable smaller jobs. Especially after adding MacOS then Windows Arm.

@illusion0001
Copy link
Contributor Author

Ok. I fixed arm64 build with simple chmod +x ‎.ci/build-linux-aarch64.sh. @illusion0001 can you cherry-pick or just copy my changes to this PR? https://github.com/q4a/rpcs3/commits/arm-ci/ Here is build result: https://github.com/q4a/rpcs3/actions/runs/12853858021

Pushed

@illusion0001 illusion0001 marked this pull request as ready for review January 19, 2025 16:03
@AniLeo AniLeo requested a review from hcorion January 19, 2025 17:03
@illusion0001
Copy link
Contributor Author

illusion0001 commented Jan 20, 2025

Arm gcc build is clang, needs fixing
https://github.com/illusion0001/rpcs3/actions/runs/12855079318/job/35840192563

@q4a
Copy link
Contributor

q4a commented Jan 20, 2025

Arm gcc build is clang, needs fixing https://github.com/illusion0001/rpcs3/actions/runs/12855079318/job/35840192563

I tested few changes and this one works pretty good:
q4a@3e2d9f7
CI result:
https://github.com/q4a/rpcs3/actions/runs/12875043123

@illusion0001
Copy link
Contributor Author

Arm gcc build is clang, needs fixing https://github.com/illusion0001/rpcs3/actions/runs/12855079318/job/35840192563

I tested few changes and this one works pretty good: q4a@3e2d9f7 CI result: https://github.com/q4a/rpcs3/actions/runs/12875043123

Updated. Also fixed windows artifact uploading build files

@illusion0001 illusion0001 force-pushed the patch-1 branch 2 times, most recently from f198291 to 11a5643 Compare January 21, 2025 05:20
@Jack54guythecoder
Copy link

What's the motivation for porting to GitHub Actions? Doesn't it have the exact same restrictions as Azure?

You can use nightly.link with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build and CI Anything related to the build process and continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants