Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: basic masonry entry list and entry content view #2493

Merged
merged 19 commits into from
Jan 22, 2025

Conversation

hyoban
Copy link
Member

@hyoban hyoban commented Jan 7, 2025

I tried Shared Element Transitions and this is what it looks like so far.

ScreenRecording_01-09-2025.12-13-54_1.MP4

It's very easy to implement in code, just set a unique sharedTransitionTag. But it also has some limitations. See Remarks from reanimated docs.

  • The biggest problem is it does not support the new architecture.
  • It does not support nested FlashList or PagerView. Therefore, the animation will be invalid after scrolling to switch entries is implemented. I have not found a solution yet.
  • I haven't found an elegant way to disable the animation on return, the current implementation is a bit inelegant. I tried Custom animation.

I'm not sure if I should keep this animation. I also looked for other solutions, like React Navigation Shared Element, but their maintenance status is even worse than reanimated.

Other information

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
follow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 2:22pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
follow-external-ssr ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 2:22pm

@follow-reviewer-bot
Copy link

Suggested PR Title:

feat(entry): improve layout and add animations for entries

Change Summary:
Enhance entry layout and animations for better user experience. Added new entry data, components, and context for smooth transitions. Modified existing screens to utilize animations and new data structure.

Code Review:
No change requests necessary.

@hyoban hyoban changed the title feat: try shared element animation feat: basic masonry entry list and entry content view Jan 22, 2025
@hyoban hyoban marked this pull request as ready for review January 22, 2025 14:23
@hyoban hyoban merged commit e569681 into dev Jan 22, 2025
11 checks passed
@hyoban hyoban deleted the feat/mobile-masonry-grid branch January 22, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant