Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(webapp): add go controller for cves endpoint #1193

Merged
merged 1 commit into from
Jan 14, 2025
Merged

feat(webapp): add go controller for cves endpoint #1193

merged 1 commit into from
Jan 14, 2025

Conversation

Dugowitch
Copy link
Contributor

@Dugowitch Dugowitch commented Nov 15, 2024 •
edited
Loading

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@jira-linking Jira Linking
Copy link

jira-linking bot commented Nov 15, 2024 •
edited
Loading

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-13545

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 11.11111% with 56 lines in your changes missing coverage. Please review.

Project coverage is 63.03%. Comparing base (5a56460) to head (32f91ef).
Report is 165 commits behind head on master.

Files with missing lines Patch % Lines
vmaas-go/webapp/controllers/cves.go 0.00% 29 Missing ⚠️
vmaas-go/webapp/controllers/utils.go 25.00% 17 Missing and 4 partials ⚠️
vmaas-go/webapp/routes/routes.go 0.00% 5 Missing ⚠️
vmaas-go/base/utils/config.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1193      +/-   ##
==========================================
+ Coverage   62.98%   63.03%   +0.05%     
==========================================
  Files          70       86      +16     
  Lines        6800     6650     -150     
==========================================
- Hits         4283     4192      -91     
+ Misses       2517     2449      -68     
- Partials        0        9       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dugowitch Dugowitch requested a review from psegedy November 15, 2024 18:01
psegedy
psegedy requested changes Nov 18, 2024
View reviewed changes
deploy/clowdapp.yaml Outdated Show resolved Hide resolved
vmaas-go/webapp/controllers/cves.go Outdated Show resolved Hide resolved
@Dugowitch Dugowitch force-pushed the cves-controller branch 3 times, most recently from 588b16e to 8fa2e3d Compare November 18, 2024 16:32
@Dugowitch Dugowitch requested a review from psegedy November 18, 2024 17:08
psegedy
psegedy reviewed Nov 18, 2024
View reviewed changes
Copy link
Member

@psegedy psegedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Please make a MR to app-interface enabling this API so we can see PR check test results.

@Dugowitch Dugowitch requested a review from psegedy November 19, 2024 12:27
@psegedy
Copy link
Member

psegedy commented Nov 19, 2024

/retest

psegedy
psegedy requested changes Nov 19, 2024
View reviewed changes
vmaas-go/webapp/routes/routes.go Outdated Show resolved Hide resolved
@psegedy
Copy link
Member

psegedy commented Nov 20, 2024

/retest

@Dugowitch Dugowitch marked this pull request as draft November 29, 2024 16:55
@Dugowitch Dugowitch force-pushed the cves-controller branch 2 times, most recently from a3bb2a3 to 537408b Compare December 2, 2024 14:52
@Dugowitch Dugowitch requested a review from psegedy December 2, 2024 15:15
@Dugowitch Dugowitch marked this pull request as ready for review December 2, 2024 15:15
@psegedy
Copy link
Member

psegedy commented Dec 9, 2024

/retest

@Dugowitch Dugowitch changed the title Add go controller for cves endpoint feat(webapp): add go controller for cves endpoint Dec 11, 2024
@Dugowitch Dugowitch marked this pull request as draft December 11, 2024 12:10
@Dugowitch Dugowitch marked this pull request as ready for review December 13, 2024 09:39
psegedy
psegedy requested changes Dec 17, 2024
View reviewed changes
vmaas-go/base/utils/gin.go Outdated Show resolved Hide resolved
vmaas-go/base/utils/gin.go Outdated Show resolved Hide resolved
@Dugowitch Dugowitch force-pushed the cves-controller branch 2 times, most recently from 4bda719 to a225b09 Compare December 19, 2024 10:56
@Dugowitch Dugowitch requested a review from psegedy December 19, 2024 13:55
@psegedy
Copy link
Member

psegedy commented Jan 6, 2025

/retest

psegedy
psegedy requested changes Jan 6, 2025
View reviewed changes
Copy link
Member

@psegedy psegedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests.test_json.TestJSON.test_json_cves[empty_json] fails because app returns EOF instead of expected error message Request body must not be empty

tests.test_cves.TestCVEsCorrect.test_get[], request is probably something like GET /api/v3/cves/'' and GIN might treat it as missing path parameter so it returns 405, please discuss with Max what to do with it, whether app should still return 200 or if tests should expect 405 in this case

@mtclinton
Copy link
Contributor

/retest

5 similar comments
@mtclinton
Copy link
Contributor

/retest

@mtclinton
Copy link
Contributor

/retest

@mtclinton
Copy link
Contributor

/retest

@mtclinton
Copy link
Contributor

/retest

@mtclinton
Copy link
Contributor

/retest

@psegedy psegedy merged commit e315631 into RedHatInsights:master Jan 14, 2025
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psegedy psegedy psegedy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dugowitch @codecov-commenter @psegedy @mtclinton