Add use_resetter and wait_for_view kwargs #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@psav Thoughts? |
mshriver
force-pushed
the
add-navigate-kwargs
branch
from
d07ca46 to
68ca832
Compare
mshriver
commented
Jan 16, 2019
mshriver
force-pushed
the
add-navigate-kwargs
branch
2 times, most recently
from
dccd05b to
d40c69e
Compare
mshriver
force-pushed
the
add-navigate-kwargs
branch
from
d40c69e to
7be5abb
Compare
mshriver
force-pushed
the
add-navigate-kwargs
branch
from
7be5abb to
279fbcf
Compare
mshriver
force-pushed
the
add-navigate-kwargs
branch
from
279fbcf to
8c92ea3
Compare
mshriver
force-pushed
the
add-navigate-kwargs
branch
3 times, most recently
from
7ba15e1 to
e45ad9d
Compare
mshriver
force-pushed
the
add-navigate-kwargs
branch
from
0d389bc to
adca211
Compare
mshriver
force-pushed
the
add-navigate-kwargs
branch
from
adca211 to
becbacd
Compare
control navigation via kwargs on navigate() use_resetter: Whether or not resetter function is called wait_for_view: timeout value for am_i_here to be true after post_navigate use_resetter defaults to True, current behavior maintained wait_for_view defaults to None, current behavior maintained Add NAVIGATE logging messages for both
mshriver
force-pushed
the
add-navigate-kwargs
branch
from
af2484f to
c020287
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
control navigation via kwargs on navigate()
use_resetter: Whether or not resetter function is called
wait_for_view: timeout value for am_i_here to be true after post_navigate
use_resetter defaults to True, current behavior maintained
wait_for_view defaults to None, current behavior maintained
FIXES #25