Allow shapes in shapes package

src/linting/extended_checks.jl

@@ -55,7 +55,7 @@
     !is_there_any_star_marker && return x == y
 
     contains(x, "QQQ") && contains(y, "QQQ") &&
         throw(BothCannotHaveStarException("Cannot both $x and $y have a star marker"))
     if contains(x, "QQQ")
         reg_exp = Regex(replace(x, "QQQ" => ".*"))
         return !isnothing(match(reg_exp, y))
@@ -292,7 +292,7 @@
 
 function check(t::InitializingWithFunctionRule, x::EXPR, markers::Dict{Symbol,String})
     # If we are not in a const statement, then we exit this function.
     haskey(markers, :const) || return
     generic_check(t, x, "Threads.nthreads()", "`Threads.nthreads()` should not be used in a constant variable.")
     generic_check(t, x, "is_local_deployment()", "`is_local_deployment()` should not be used in a constant variable.")
     generic_check(t, x, "Deployment.is_local_deployment()", "`Deployment.is_local_deployment()` should not be used in a constant variable.")
@@ -348,11 +348,11 @@
 check(t::PtrRule, x::EXPR) = generic_check(t, x, "Ptr{hole_variable}(hole_variable)")
 
 function check(t::ArrayWithNoTypeRule, x::EXPR, markers::Dict{Symbol,String})
     haskey(markers, :filename) || return
     contains(markers[:filename], "src/Compiler") || return
 
     haskey(markers, :macrocall) && markers[:macrocall] == "@match" && return
     haskey(markers, :macrocall) && markers[:macrocall] == "@matchrule" && return
 
     generic_check(t, x, "[]", "Need a specific Array type to be provided.")
 end
@@ -392,7 +392,7 @@
 end
 
 function check(t::UnsafeRule, x::EXPR, markers::Dict{Symbol,String})
     haskey(markers, :function) || return
     isnothing(match(r"_unsafe_.*", markers[:function])) || return
     isnothing(match(r"unsafe_.*", markers[:function])) || return
 
@@ -488,7 +488,7 @@
 end
 
 function check(t::RelPathAPIUsageRule, x::EXPR, markers::Dict{Symbol,String})
     haskey(markers, :filename) || return
     contains(markers[:filename], "src/Compiler/Front") || return
 
     generic_check(t, x, "hole_variable::RelPath", "Usage of type `RelPath` is not allowed in this context.")
@@ -500,11 +500,13 @@
 end
 
 function check(t::NonFrontShapeAPIUsageRule, x::EXPR, markers::Dict{Symbol,String})
     haskey(markers, :filename) || return
     # In the front-end and in FFI, we are allowed to refer to `Shape`
     contains(markers[:filename], "src/FrontCompiler") && return
     contains(markers[:filename], "src/FFI") && return
     contains(markers[:filename], "src/FrontIR") && return
+    # Allow usage in shapes package
+    contains(markers[:filename], "packages/Shapes") && return
     # Allow usage in Front benchmarks
     contains(markers[:filename], "bench/Front") && return
     # Allow usages in tests
@@ -535,7 +537,7 @@
     is_safe_macro_call(y) =
         y.head == :macrocall && y.args[1].head == :IDENTIFIER && y.args[1].val == "@safe"
 
     is_safe_literal(x) = x.head in [:NOTHING,
                                     :INTEGER,
                                     :FLOAT,
                                     :TRUE,