Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mitigate problem with ChainAuthHandler #525

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

halber
Copy link
Contributor

@halber halber commented Jun 6, 2024

A problem with the ChainAuthHandler was introduced in vert.x version 4.5.6. To mitigate the issue, we do not use the vert.x ChainAuthHandler when only one AuthenticationHandler is used. The problem still exists when more than one AuthenticationHandler is used.

vert-x3/vertx-web#2611

A problem with the ChainAuthHandler was introduced in vert.x version
4.5.6. To mitigate the issue, we do not use the vert.x
ChainAuthHandler when only one AuthenticationHandler is used. The
problem still exists when more than one AuthenticationHandler is used.

vert-x3/vertx-web#2611
@halber halber requested a review from a team as a code owner June 6, 2024 09:36
Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@carlspring carlspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@halber halber merged commit bab36af into main Jun 6, 2024
9 checks passed
@halber halber deleted the fix/ChainAuthHandler branch June 6, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants