Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eask-cli: Add version 0.10.3 #14675

Closed
wants to merge 1 commit into from

Conversation

jcs090218
Copy link
Contributor

Copy link
Contributor

github-actions bot commented Jan 4, 2025

All changes look good.

Wait for review from human collaborators.

eask-cli

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@aliesbelik aliesbelik added the package-request-needed Need package-request issue label Jan 7, 2025
@jcs090218
Copy link
Contributor Author

@aliesbelik Hi! I wonder what the label package-request-needed means. Does it need to meet specific criteria? 🤔 Thanks!

@danielpauldd
Copy link
Contributor

package-request-needed means: please create an package-request issue before you file a PR (see CONTRIBUTING)

@jcs090218
Copy link
Contributor Author

Opened in #14740.

@jcs090218 jcs090218 mentioned this pull request Jan 14, 2025
6 tasks
@aliesbelik aliesbelik linked an issue Jan 15, 2025 that may be closed by this pull request
6 tasks
@aliesbelik aliesbelik removed the package-request-needed Need package-request issue label Jan 15, 2025
@aliesbelik
Copy link
Collaborator

Please add arm64 version as well.

@jcs090218
Copy link
Contributor Author

Please add arm64 version as well.

Done.

@jcs090218 jcs090218 changed the title eask-cli: Add version 0.10.2 eask-cli: Add version 0.10. Jan 15, 2025
@jcs090218 jcs090218 changed the title eask-cli: Add version 0.10. eask-cli: Add version 0.10.3 Jan 15, 2025
@jcs090218
Copy link
Contributor Author

jcs090218 commented Jan 15, 2025

The latest version should fix the arm64 build. 🤔

@jcs090218
Copy link
Contributor Author

Hmmm... can someone point out to me why the arm64 failed? 😓

@aliesbelik
Copy link
Collaborator

Hmmm... can someone point out to me why the arm64 failed? 😓

Fails not arm64, fails the formatting.

  1. Please revert to 4 spaces tabs, as per Contributing Guide.
  2. Fix EOF.

@jcs090218 jcs090218 force-pushed the feat/eask-cli branch 2 times, most recently from 033f482 to 913d2ec Compare January 16, 2025 18:55
@aliesbelik
Copy link
Collaborator

Damn, simply use /bin/formatjson.ps1 eask-cli locally to fix formatting.
I cannot push to your PR.

@jcs090218
Copy link
Contributor Author

Damn, simply use /bin/formatjson.ps1 eask-cli locally to fix formatting.

I applied it but there is no changes. 🤔

$ git status
On branch feat/eask-cli
Your branch is up to date with 'origin/feat/eask-cli'.

nothing to commit, working tree clean

@jcs090218
Copy link
Contributor Author

jcs090218 commented Jan 16, 2025

I cannot push to your PR.

Yeah, there is no button allow edits and access to secrets by maintainers for me to click. I guess it's because I'm opening PRs from the org. 🤔

Can you re-run the workflow? I have force pushed a new push since the last tests.

@jcs090218
Copy link
Contributor Author

Hmmm... the tests still fail. Now, I have completely no clue why it failed. 😕

@jcs090218
Copy link
Contributor Author

I've created the test (add my own bucket), and it seems to be working: https://github.com/emacs-eask/packaging/actions/runs/12815723907/job/35735044433.

@jcs090218
Copy link
Contributor Author

I saw other files have spaces instead of tabs so I've reverted back to use spaces instead. 🤔

@jcs090218
Copy link
Contributor Author

Can someone help me with this? Thanks! 😓

@jcs090218
Copy link
Contributor Author

Damn, simply use /bin/formatjson.ps1 eask-cli locally to fix formatting.

I got the answer from GitHub. I need to fork to my own personal account to enable this feature. I have opened another PR in #14767; therefore, closing this.

@jcs090218 jcs090218 closed this Jan 21, 2025
@jcs090218 jcs090218 mentioned this pull request Jan 21, 2025
1 task
@jcs090218 jcs090218 deleted the feat/eask-cli branch January 22, 2025 04:34
@jcs090218 jcs090218 restored the feat/eask-cli branch January 22, 2025 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: eask-cli
3 participants