Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for MW 1.39 #84

Merged
merged 4 commits into from
Jan 5, 2025
Merged

Add CI for MW 1.39 #84

merged 4 commits into from
Jan 5, 2025

Conversation

paladox
Copy link
Contributor

@paladox paladox commented Jan 4, 2025

  • Bumps version
  • Fixes phpcs
  • Bumps SMW requirements

@paladox
Copy link
Contributor Author

paladox commented Jan 4, 2025

Dunno how to fix:

1) SMT\Tests\HookRegistryTest::testRegister
Expectation failed for method name is "getRequest" when invoked at least once.
Expected invocation at least once but it never occurred.

2) SMT\Tests\Integration\MetaTagsContentGenerationIntegrationTest::testAddStandardMetaTag
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => Array (
-        0 => 'keywords'
-        1 => 'KeywordMetaTag,AnotherKeywordMetaTag'
+        0 => 'static:tag'
+        1 => 'withStatic<Content>'
     )
-    1 => Array (...)
-    2 => Array (...)
 )

/var/www/html/extensions/SemanticMetaTags/tests/phpunit/Integration/MetaTagsContentGenerationIntegrationTest.php:102
/var/www/html/tests/phpunit/MediaWikiIntegrationTestCase.php:500
/var/www/html/extensions/SemanticMetaTags/extensions/SemanticMediaWiki/tests/phpunit/SMWIntegrationTestCase.php:205

3) SMT\Tests\Integration\MetaTagsContentGenerationIntegrationTest::testAddOpenGraphMetaTag
Failed asserting that false is true.

/var/www/html/extensions/SemanticMetaTags/tests/phpunit/Integration/MetaTagsContentGenerationIntegrationTest.php:131
/var/www/html/tests/phpunit/MediaWikiIntegrationTestCase.php:500
/var/www/html/extensions/SemanticMetaTags/extensions/SemanticMediaWiki/tests/phpunit/SMWIntegrationTestCase.php:205

* Bumps version
* Fixes phpcs
* Bumps SMW requirements
@paladox
Copy link
Contributor Author

paladox commented Jan 4, 2025

Dunno how to fix:

1) SMT\Tests\HookRegistryTest::testRegister
Expectation failed for method name is "getRequest" when invoked at least once.
Expected invocation at least once but it never occurred.

2) SMT\Tests\Integration\MetaTagsContentGenerationIntegrationTest::testAddStandardMetaTag
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => Array (
-        0 => 'keywords'
-        1 => 'KeywordMetaTag,AnotherKeywordMetaTag'
+        0 => 'static:tag'
+        1 => 'withStatic<Content>'
     )
-    1 => Array (...)
-    2 => Array (...)
 )

/var/www/html/extensions/SemanticMetaTags/tests/phpunit/Integration/MetaTagsContentGenerationIntegrationTest.php:102
/var/www/html/tests/phpunit/MediaWikiIntegrationTestCase.php:500
/var/www/html/extensions/SemanticMetaTags/extensions/SemanticMediaWiki/tests/phpunit/SMWIntegrationTestCase.php:205

3) SMT\Tests\Integration\MetaTagsContentGenerationIntegrationTest::testAddOpenGraphMetaTag
Failed asserting that false is true.

/var/www/html/extensions/SemanticMetaTags/tests/phpunit/Integration/MetaTagsContentGenerationIntegrationTest.php:131
/var/www/html/tests/phpunit/MediaWikiIntegrationTestCase.php:500
/var/www/html/extensions/SemanticMetaTags/extensions/SemanticMediaWiki/tests/phpunit/SMWIntegrationTestCase.php:205

Fixed the first one. The 2nd one I think is due to Action::getActionName. I'm not sure how to fix it because there's no way on supplying it being mocked to it.

@paladox
Copy link
Contributor Author

paladox commented Jan 4, 2025

I've been looking at this for hours and have tried a lot of potential solutions with none of it being successful. I'm wondering if you @gesinn-it-gea / @gesinn-it-ilm have any ideas? This can be merged as is as at least ci runs although not successfully. I'm not fully sure it's just getActionName.

@paladox
Copy link
Contributor Author

paladox commented Jan 5, 2025

Oh using

		// @see LinksUpdateTest
 		$this->mwHooksHandler = $this->testEnvironment->getUtilityFactory()->newMwHooksHandler();
 		$this->mwHooksHandler->deregisterListedHooks();
 		$this->mwHooksHandler->invokeHooksFromRegistry();

from https://github.com/SemanticMediaWiki/SemanticMetaTags/pull/79/files#diff-7602a4b07dd8c1965554073021889163ea215f8fd8dfbe8230f07ba76f336ded worked.

@paladox paladox mentioned this pull request Jan 5, 2025
@JeroenDeDauw JeroenDeDauw merged commit 4e180f1 into master Jan 5, 2025
1 check passed
@JeroenDeDauw JeroenDeDauw deleted the add-ci-1-39 branch January 5, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants