fix: gather sources does not cancelled on refresh #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a signal reason as Error object.
Added a cancel() method to GatherState, instead of providing signal to constructor.
Enabled cancellation of gather sources by locking only the UI during refresh, not the entire refresh process.
|
I will test it. |
Yes, it is contained in this PR. |
|
OK. |
Closed
|
Thanks. Merged. |
|
I have found the bug. If I |
Shougo
reviewed
Jan 7, 2025
| this.#aborter.abort({ reason: "quit" }); | ||
| const reason = new QuitAbortReason(); | ||
| this.#aborter.abort(reason); | ||
| /* no await */ this.#cancelGatherStates([], reason); |
There was a problem hiding this comment.
It must not be canceled. Because if it is canceled, resume feature does not work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled cancellation of gather sources by locking only the UI during refresh, not the entire refresh process.
This PR includes 3 cumulative commits. If necessary, these can be separated into individual PRs.