add configuration options for allowing zero-conf channels #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dominion5254
requested changes
May 16, 2024
Comment on lines
+35
to
+39
| currentError(config) { | ||
| if (config.advanced["protocol-zero-conf"] && !config.advanced["protocol-option-scid-alias"]) { | ||
| return "'Advanced > Enable option-scid-alias Channels' must be enabled to enable zero-conf channels'"; | ||
| } | ||
| }, |
There was a problem hiding this comment.
From the lnd documentation, it seem zero-conf also requires anchor channels.
While anchors are enabled by default, I believe we should probably include a conditional to confirm.
There was a problem hiding this comment.
added an additional config rule for it
scripts/services/getConfig.ts
Outdated
Comment on lines
433
to
435
| "description": | ||
| "Set to enable support for zero-conf channels. This requires the option-scid-alias flag to also be set.\n", | ||
| "default": false, |
There was a problem hiding this comment.
Suggested change
| "description": | |
| "Set to enable support for zero-conf channels. This requires the option-scid-alias flag to also be set.\n", | |
| "default": false, | |
| "description": | |
| "Set to enable support for zero-conf channels. This requires the option-scid-alias flag to also be set.\n", | |
| "warning": "Zero-conf channels are channels that do not require confirmations to be used. Because of this, the fundee must trust the funder to not double-spend the channel and steal the balance of the channel.", | |
| "default": false, |
…ero-conf channels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am experimenting with Zeus Olympus LSP, which uses 0-conf (zero-conf) channels for easy onboarding.
This requires two options enabled in LND: https://github.com/lightningnetwork/lnd/blob/master/docs/zero_conf_channels.md
This PR adds those configuration options (keeping the default to false, as it is now).
In Zeus, before:
After enabling the new settings: