-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEAV-65] Background Texture View 방식 변경 #20
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file removed
BIN
-1.01 MB
...es/Images/Images.xcassets/background_default.imageset/[email protected]
Binary file not shown.
Binary file removed
BIN
-2.19 MB
...es/Images/Images.xcassets/background_default.imageset/[email protected]
Binary file not shown.
5 changes: 3 additions & 2 deletions
5
...background_default.imageset/Contents.json → ...cassets/bg-texture.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+316 KB
.../DesignCore/Resources/Images/Images.xcassets/bg-texture.imageset/bg-texture.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.2 MB
...signCore/Resources/Images/Images.xcassets/bg-texture.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.59 MB
...signCore/Resources/Images/Images.xcassets/bg-texture.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BackgroundTextureViewModifier
업데이트 승인 및 개선 제안BackgroundTextureViewModifier
의 변경사항은BackgroundTextureView
의 업데이트와 잘 통합되어 있습니다.colorType
매개변수를 추가한 것은 적절한 변경입니다.SwiftLint 경고를 해결하기 위해 다음과 같이 수정을 제안합니다:
fileprivate
대신private
를 사용하면 SwiftLint 경고를 해결하고 더 명확한 접근 제어를 제공할 수 있습니다. 이 구조체가 파일 외부에서 사용되지 않는다면private
로 충분할 것 같습니다.