Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure compatibility with Java 21 #1615

Merged
merged 14 commits into from
Nov 25, 2024
Merged

Ensure compatibility with Java 21 #1615

merged 14 commits into from
Nov 25, 2024

Conversation

l-1squared
Copy link
Collaborator

No description provided.

@l-1squared l-1squared force-pushed the support-java-21 branch 7 times, most recently from 6d0e5ea to b35839d Compare October 25, 2024 13:16
@@ -9,7 +9,7 @@ jobs:
ANDROID: true
strategy:
matrix:
java: [ '11', '17', '19']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

19 will be omitted completely?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, 19 was not an LTS release and is thus not supported anymore. Once I've got this, I'd also like to add the two newest versions.

@@ -1,10 +1,12 @@
# Release v2.0.0
## Breaking changes
## Backward incompatible changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, backward incompatible with respect to...? It's a bit confusing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the previous version. I refraine from using "breaking" because I hope that the changes do not actually break anything
(Java 17 is pretty much required if you do java by now, and the gradle issue should only affect some fringe cases). therefore I wanted to use less agressive wording

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, it's just wording in the end, but "breaking changes" is somehow "well-known"; the new wording seems... a bit off. But probably it's rather on my side than a general issue ;)

@l-1squared l-1squared merged commit f8f5ed5 into master Nov 25, 2024
18 checks passed
@l-1squared l-1squared deleted the support-java-21 branch November 25, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants