-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure compatibility with Java 21 #1615
Conversation
6d0e5ea
to
b35839d
Compare
Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
65748ba
to
e646154
Compare
Signed-off-by: l-1squared <[email protected]>
0aa31e2
to
6ed712f
Compare
@@ -9,7 +9,7 @@ jobs: | |||
ANDROID: true | |||
strategy: | |||
matrix: | |||
java: [ '11', '17', '19'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
19 will be omitted completely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, 19 was not an LTS release and is thus not supported anymore. Once I've got this, I'd also like to add the two newest versions.
@@ -1,10 +1,12 @@ | |||
# Release v2.0.0 | |||
## Breaking changes | |||
## Backward incompatible changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, backward incompatible with respect to...? It's a bit confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the previous version. I refraine from using "breaking" because I hope that the changes do not actually break anything
(Java 17 is pretty much required if you do java by now, and the gradle issue should only affect some fringe cases). therefore I wanted to use less agressive wording
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, it's just wording in the end, but "breaking changes" is somehow "well-known"; the new wording seems... a bit off. But probably it's rather on my side than a general issue ;)
No description provided.