Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gds): use .oas from user projects when available #27

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

htfab
Copy link
Contributor

@htfab htfab commented Jan 13, 2025

No description provided.

@urish
Copy link
Member

urish commented Jan 13, 2025

Thanks!

We should move this step to be part of tt-support-tools (and probably the other preprocessing steps, but that could be a part of a future task). Otherwise, local builds will stop working (or we'll have to add all the steps to BUILDING.md, but our goal is to keep things simple)

@urish
Copy link
Member

urish commented Jan 13, 2025

One advantage of moving this to tt-support-tools is that we will be able to just use the pip installed klayout for this

@htfab
Copy link
Contributor Author

htfab commented Jan 13, 2025

Yes, it would make sense to include it in copy_macros(). The reason I've put it in the workflow is that it currently interferes with our sky130_density_fix patch. Either we need to do the conversion before applying sky130_density_fix (thus do it in the workflow, as in this PR), or we modify sky130_density_fix to handle .oas as well as .gds. By the way, do we still need the density fix or was it fixed upstream?

@urish
Copy link
Member

urish commented Jan 13, 2025

By the way, do we still need the density fix or was it fixed upstream?

That's a very good question - can you please ask on Slack?

The plan was for the fix to go away after tt10, which is why we haven't included it in tt-support-tools.

Another possible interim solution would be to adjust the density fix script to read/write oas (since it's also based on klayout)

@htfab
Copy link
Contributor Author

htfab commented Jan 13, 2025

Another possible interim solution would be to adjust the density fix script to read/write oas (since it's also based on klayout)

Looks like the density fix script works with oas files as-is, we just need to call it with an .oas argument.
So I moved the actual conversion to tt-support-tools and this PR is now reduced to an extra call to the density fix for .oas files.

@urish
Copy link
Member

urish commented Jan 13, 2025

We also need to update the submodule, right?

@htfab
Copy link
Contributor Author

htfab commented Jan 13, 2025

Yes

@urish urish merged commit d0cafb5 into TinyTapeout:main Jan 13, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants