Add package crypto, move files from tongsuogo to crypto #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongbeiouba
requested review from
InfoHunter,
itomsawyer,
wa5i,
zzl360 and
a team
InfoHunter
reviewed
Dec 21, 2023
InfoHunter
reviewed
Dec 21, 2023
这个动机是啥？ |
Make tongsuogo be a drop-in replacement of golang standard crypto package. |
动机是要把SM4算法挪到crypto文件夹下，成为一个单独的package，就像之前的SHA256、SM3等模块，独立成包，而不是都放在tongsuogo里面。 但是发现牵一发而动全身，受影响的模块非常多，那就只能把协议无关的文件都移动到crypto下。tongsuogo依赖crypto，类似于libssl依赖libcrypto一样。 |
|
有冲突 |
Move protocol-independent files to crypto package. Remove gmsm/sm3, test sm3 with real test data.
Fixed |
itomsawyer
reviewed
Dec 25, 2023
|
|
||
| // SetDHParameters sets the DH group (DH parameters) used to | ||
| // negotiate an emphemeral DH key during handshaking. | ||
| func (c *Ctx) SetDHParameters(dh *DH) error { |
| @@ -26,48 +34,48 @@ type SM4Encrypter interface { | |||
| } | |||
|
|
|||
| type SM4Decrypter interface { | |||
| DecryptionCipherCtx | |||
| // crypto.DecryptionCipherCtx | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move protocol-independent files to crypto package.
Remove gmsm/sm3, test sm3 with real test data.