fixed anti-pattern, formating and typo #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tripletex.create_session_token should not have to be null-checked when behaviour will result in an Exception, this is an anti-pattern. Rather raise Exception explicitly. Fixed parameter typo in tripletex.map. Formated empty space characters. and PEP-8 method-spacing formating.
tlxtellef
requested changes
Sep 12, 2023
| else: | ||
| print(r.status_code, r.text, r.reason) | ||
|
|
||
| raise Exception(r.status_code, r.text, r.reason) |
There was a problem hiding this comment.
Since this is getting converted in to throwing an exception the exception type it throws should be as accurate as practically possible.
If none of the types here fit then either a new custom exception type should be made by extending Exception or use RuntimeError.
There is a very informative answer on StackOverflow regarding this here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tripletex.create_session_token should not have to be null-checked when behaviour will result in an Exception, this is an anti-pattern. Rather raise Exception explicitly.
Fixed parameter typo in tripletex.map.
Formated empty space characters.
and PEP-8 method-spacing formating.