80 packaging #82
Merged
80 packaging #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamuri
requested changes
Jan 15, 2025
tamuri
reviewed
Jan 15, 2025
pyproject.toml
Outdated
| ] | ||
|
|
||
| [project.scripts] | ||
| shortlist = "shortlister.main:run_controller" |
There was a problem hiding this comment.
I'm experience some strange behaviour - when I run shortlist, I need to quit out of the program twice. Are you seeing the same?
There was a problem hiding this comment.
Same bug for me too, I've been looking into this but haven't found a solution yet
tamuri
approved these changes
Jan 17, 2025
src/shortlister/main.py
Outdated
| webview.start(run_controller, args=[window]) | ||
| else: | ||
| run_controller(None) | ||
| def boot(): |
There was a problem hiding this comment.
This should typically be named something like start, run or main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add source and wheel distributions