WIP: Update FIREARMS to use beta version of HOFF framework using axios. (Do not merge these changes to the master branch) #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… about starting firearms locally
SavantDhindsaHO
changed the title
1.Updated the package.json file to use beta version of HOF. 2.Updated pdf-upload.js, auth-token.js, file-upload.js and pdf.js file to use fields related to axios. 3.Updated all the unit tests related to axios request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update FIREARMS to use beta version of HOFF framework using axios.
Why?
Request module is deprecated and showing critical vulnerability in snyk scan.
How?
Used the beta version of HOF framework and updated the fields in request used in axios.