Hoff-714 Firearms: Layout table Storage Add Another Address #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaolaDMadd-Pro
force-pushed
the
Hoff-714-accessibility-address-table
branch
from
75d5f02 to
493934f
Compare
- update partials view in the following files: 1. apps/new-dealer/views/partials/add-another-address-summary.htm 2. apps/museums/views/partials/add-another-address-summary.html 3. apps/common/views/partials/add-another-address-summary.html 4. apps/shooting-clubs/views/partials/add-another-address-summary.html - update .snyk - update package.json and yarn.lock - added pull-request-template
PaolaDMadd-Pro
force-pushed
the
Hoff-714-accessibility-address-table
branch
from
493934f to
df8c9e1
Compare
|
Looks good to me |
davidafolabiHO
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Improved accessibility for address table
Why?
As per bug jira ticket Hoff-714
How?
update all partials/add-another-address-summary.html following GDS guidance.
added
govuk-visually-hiddenclass to keep the original design as per UCD suggestion.Testing?
sanity test and screen reader for add-another-address-summary.html
Screenshots (optional)
Anything Else? (optional)
Check list