Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds password ui validation #297

Merged
merged 1 commit into from
Jul 8, 2024
Merged

feat: adds password ui validation #297

merged 1 commit into from
Jul 8, 2024

Conversation

jtucholski
Copy link
Contributor

Adds password UI validation and should close #272

Implements following UI changes:

  • New password messages when the password does/doesn't meet the minimum length or include one number
  • New message when the confirm password doesn't match the new password
  • Form submission is blocked if any of the validation rules fail

image

@jtucholski jtucholski marked this pull request as ready for review July 8, 2024 16:39
calisio
calisio approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@calisio calisio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@calisio calisio merged commit 6f4a26a into UnlockedLabs:main Jul 8, 2024
4 checks passed
@jtucholski jtucholski deleted the feat-password-ui branch August 1, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calisio calisio calisio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add password requirements to UI
2 participants
@jtucholski @calisio