Update executeJobModal.tsx #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TurtIeSocks
requested changes
Nov 28, 2023
| @@ -41,7 +44,16 @@ export const ExecuteJobModal = ({ closeModal, devices, jobId }: ExecuteJobModalP | |||
| <Text h3>Execute {jobId}</Text> | |||
| </Modal.Header> | |||
| <Modal.Body> | |||
| {devices && ( | |||
| <Input | |||
There was a problem hiding this comment.
You should use the search component from https://github.com/UnownHash/Rotom/blob/main/packages/client/src/app/status/search.tsx
Example implementation:
na-ji
requested changes
Nov 28, 2023
Comment on lines
17
to
18
| const filteredDevices = devices?.filter(device => | ||
| device.deviceId?.includes(filter) || device.origin?.includes(filter)) || []; |
There was a problem hiding this comment.
You should memoize the filtering by using the useMemo hook. Also, as mentionned by GitHub, your indentation isn't right here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add search filter