Merge pull request #938 from VisActor/fix/3d-bounds

fix: fix issue with 3d draw dirtybounds
VisActor · Jan 24, 2024 · a6eda54 · a6eda54
2 parents b802c35 + 95ba7a8
commit a6eda54
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/common/changes/@visactor/vrender-core/fix-3d-bounds_2024-01-24-12-10.json b/common/changes/@visactor/vrender-core/fix-3d-bounds_2024-01-24-12-10.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@visactor/vrender-core",
+      "comment": "fix: fix issue with 3d draw dirtybounds",
+      "type": "none"
+    }
+  ],
+  "packageName": "@visactor/vrender-core"
+}
diff --git a/packages/vrender-core/src/render/contributions/render/draw-contribution.ts b/packages/vrender-core/src/render/contributions/render/draw-contribution.ts
@@ -146,8 +146,8 @@ export class DefaultDrawContribution implements IDrawContribution {
 
     // 如果存在3d视角，那么不使用dirtyBounds
     if (stage.camera) {
-      this.dirtyBounds.clear();
-      this.backupDirtyBounds.clear();
+      this.dirtyBounds.setValue(-Infinity, -Infinity, Infinity, Infinity);
+      this.backupDirtyBounds.setValue(-Infinity, -Infinity, Infinity, Infinity);
     }
 
     this.clearScreen(renderService, context, drawContext);
@@ -276,8 +276,8 @@ export class DefaultDrawContribution implements IDrawContribution {
     // 渲染
     const incrementalContext = incrementalLayer.layer.getNativeHandler().getContext();
     const idc = incrementalLayer.drawContribution || container.get(IncrementalDrawContribution);
-    idc.dirtyBounds.clear();
-    idc.backupDirtyBounds.clear();
+    idc.dirtyBounds.setValue(-Infinity, -Infinity, Infinity, Infinity);
+    idc.backupDirtyBounds.setValue(-Infinity, -Infinity, Infinity, Infinity);
     (idc as any).draw(this.currentRenderService, {
       ...drawContext,
       drawContribution: idc,