Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add leaderboard system #217

Merged
merged 1 commit into from
Nov 15, 2023
Merged

✨ Add leaderboard system #217

merged 1 commit into from
Nov 15, 2023

Conversation

w305jack
Copy link
Collaborator

Why need this change? / Root cause:

  • add leaderboard system feature

Changes made:

Test Scope / Change impact:

  • leaderboard system

@w305jack w305jack force-pushed the feature/leader-board branch 5 times, most recently from a51e21a to eff0889 Compare November 15, 2023 15:47
Wally5077
Wally5077 requested changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done.

.../src/main/kotlin/tw/waterballsa/utopia/utopiagamification/leaderboard/LeaderBoardListener.kt Outdated Show resolved Hide resolved
.../src/main/kotlin/tw/waterballsa/utopia/utopiagamification/leaderboard/LeaderBoardListener.kt Outdated Show resolved Hide resolved
.../src/main/kotlin/tw/waterballsa/utopia/utopiagamification/leaderboard/LeaderBoardListener.kt Outdated Show resolved Hide resolved
@w305jack w305jack force-pushed the feature/leader-board branch 3 times, most recently from c53f755 to 439d739 Compare November 15, 2023 16:13
@w305jack w305jack force-pushed the feature/leader-board branch from 439d739 to aedc636 Compare November 15, 2023 16:15
Wally5077
Wally5077 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

m1a2st
m1a2st approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

23.3% 23.3% Coverage
0.0% 0.0% Duplication

@w305jack w305jack merged commit d5ee9cf into main Nov 15, 2023
2 checks passed
@w305jack w305jack deleted the feature/leader-board branch November 15, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1a2st m1a2st m1a2st approved these changes

@Wally5077 Wally5077 Wally5077 approved these changes

@shmily7829 shmily7829 Awaiting requested review from shmily7829

@frankvicky frankvicky Awaiting requested review from frankvicky

@wow890209 wow890209 Awaiting requested review from wow890209

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[任務] 排行榜 - 查詢自己
3 participants
@w305jack @Wally5077 @m1a2st