[LINKER-X] 비회원 로그인시 일단 무조건 회원가입 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktj1997
commented
Jan 27, 2024
Comment on lines
+10
to
+11
| Optional<User> findByOAuthVendorAndOAuthIdentifier( | ||
| OAuthVendor oAuthVendor, String oAuthIdentifier); |
There was a problem hiding this comment.
이메일은 변경 가능한 값이기 떄문에, kakao에서 내려주는 id(oAuthIdentifier)와
oAuthVendor(kakao, ...)를 통해서 회원 여부를 판단했습니다
Comment on lines
+74
to
+77
| String redirectUri = | ||
| String.format( | ||
| "%s?accessToken=%s&refreshToken=%s", clientOriginHost, accessToken, refreshToken); | ||
| getRedirectStrategy().sendRedirect(request, response, redirectUri); |
There was a problem hiding this comment.
최종적으로 비회원도 회원가입 진행후 동일하게 accessToken과 refreshToken을 내립니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📍 작업 배경 #
AS-IS: Kakao에서 받아온 정보를 모두 파라미터에 담아서 Client에 Redirect처리
TO-BE: 비회원일 경우 회원가입을 진행, 그 이후 access와 refresh를 파라미터에 담아서 내림
📝 작업 내용 #
💬 코멘트 #