prohibit triggering a query when the query is null in the indexVM #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s null
There is a special case :
// when we launch the search when the query is not null except the case when we query with
// an empty string after we had already launched a search
// ex: query with string1 we got result after we remove the key and launch the search
// we should get all the results
mastermind1981
changed the title
|
@YousefED could you please check the pull, i don't now if ti will compile fine in ts ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull will prohibit launching search when the query is null Object is null.
With this pull we will be able to have a page with
eui-filterwith aeui-enabled = truewithout triggering a search when we didn't already have a query and with indexVM.false.Besides that, no search will be triggered when other attributes of indexVM are changed if the query is null.
In the added code there is a special case when we launch the search even if the query is null, when it's old value is not null. The scenario is this:
This scenario will work with pull.
To prevent triggering the search on page load ng-init="indexVM.autoLoad = true" must be added.