Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only run this.search() when a query is set #58

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

joshbedo
Copy link

No description provided.

@YousefED
Copy link
Owner

  1. Seems you've added some code changes in demo.html which weren't intential
  2. can't we move the null checks to a more centralized place, instead of adding 5+ of them all around?

Thanks,

@joshbedo
Copy link
Author

Cool i can make those changes. Everything else make sense? I'll create some method like isQuerySet to check the value.

@joshbedo joshbedo force-pushed the jb-removing-overfetch branch 2 times, most recently from aedaea1 to 7b67bda Compare October 19, 2015 15:45
@joshbedo joshbedo force-pushed the jb-removing-overfetch branch from 7b67bda to f9d0976 Compare October 19, 2015 15:46
@joshbedo
Copy link
Author

Just made changes let me know if everything looks alright.

@YousefED
Copy link
Owner

Hi, I didn't mean moving the null checks to a separate method. I meant can't we have 1 check further down / up in the call stack and thus centralize the logic?

@joshbedo
Copy link
Author

ahh okay, sorry i misunderstood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants