Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Exponential Backoff for Route53 Throttling in dns_aws.sh #6205

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Add Exponential Backoff for Route53 Throttling in dns_aws.sh #6205

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a5df35
Route53 Exponential backoff
foxdalas Jan 18, 2025
21d9c2e
Merge branch 'dev' into route53_ratelimit
foxdalas Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 37 additions & 13 deletions dnsapi/dns_aws.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,6 @@ aws_rest() {
_debug2 CredentialScope "$CredentialScope"

StringToSign="$Algorithm\n$RequestDate\n$CredentialScope\n$HashedCanonicalRequest"

_debug2 StringToSign "$StringToSign"

kSecret="AWS4$AWS_SECRET_ACCESS_KEY"
Expand Down Expand Up @@ -361,20 +360,45 @@ aws_rest() {
url="$AWS_URL/$ep?$qsr"
fi

if [ "$mtd" = "GET" ]; then
response="$(_get "$url")"
else
response="$(_post "$data" "$url")"
fi
# Exponential backoff
max_retries=10
attempt=1
base_sleep=5

_ret="$?"
_debug2 response "$response"
if [ "$_ret" = "0" ]; then
if _contains "$response" "<ErrorResponse"; then
_err "Response error:$response"
return 1
while [ "$attempt" -le "$max_retries" ]; do
if [ "$mtd" = "GET" ]; then
response="$(_get "$url")"
else
response="$(_post "$data" "$url")"
fi
fi

_ret="$?"
_debug2 response "$response"

if [ "$_ret" = "0" ]; then
if _contains "$response" "<ErrorResponse"; then
_err "Response error:$response"
if echo "$response" | grep -Eq "<Code>(Throttling|RequestThrottled|RateLimit)</Code>|<Message>Rate exceeded</Message>"; then
_err "AWS throttling encountered, attempt $attempt"
attempt=$(_math "$attempt" + 1)
if [ "$attempt" -le "$max_retries" ]; then
sleep_time=$(_math "$base_sleep" "*" 2 "^" "$((attempt - 1))")
_err "Sleeping $sleep_time seconds before retry..."
_sleep "$sleep_time"
continue
else
_err "Max retries ($max_retries) reached. Giving up."
return 1
fi
else
return 1
fi
fi
else
return "$_ret"
fi
break
done

return "$_ret"
}
Loading