Rename method

aerni · Jul 20, 2024 · 5219c51 · 5219c51
1 parent 9b296cd
commit 5219c51
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 6 deletions.
diff --git a/src/Sitemaps/BaseSitemapUrl.php b/src/Sitemaps/BaseSitemapUrl.php
@@ -24,8 +24,7 @@ abstract public function priority(): string|self|null;
 
     abstract public function site(): string|self;
 
-    // TODO: Can we use the canonicalPointsToAnotherUrl method instead? It's the same logic.
-    public function isCanonicalUrl(): bool
+    public function canonicalTypeIsCurrent(): bool
     {
         return true;
     }

diff --git a/src/Sitemaps/Collections/CollectionSitemap.php b/src/Sitemaps/Collections/CollectionSitemap.php
@@ -19,7 +19,7 @@ public function urls(): Collection
 
         return $this->urls = $this->entries()
             ->map(fn ($entry) => new EntrySitemapUrl($entry, $this))
-            ->filter(fn ($url) => $url->isCanonicalUrl());
+            ->filter(fn ($url) => $url->canonicalTypeIsCurrent());
     }
 
     protected function entries(): Collection

diff --git a/src/Sitemaps/Collections/EntrySitemapUrl.php b/src/Sitemaps/Collections/EntrySitemapUrl.php
@@ -75,7 +75,7 @@ public function site(): string
         return $this->entry->locale();
     }
 
-    public function isCanonicalUrl(): bool
+    public function canonicalTypeIsCurrent(): bool
     {
         return $this->entry->seo_canonical_type == 'current';
     }

diff --git a/src/Sitemaps/Taxonomies/TaxonomySitemap.php b/src/Sitemaps/Taxonomies/TaxonomySitemap.php
@@ -21,7 +21,7 @@ public function urls(): Collection
             ->merge($this->termUrls())
             ->merge($this->collectionTaxonomyUrls())
             ->merge($this->collectionTermUrls())
-            ->filter(fn ($url) => $url->isCanonicalUrl());
+            ->filter(fn ($url) => $url->canonicalTypeIsCurrent());
     }
 
     protected function taxonomyUrls(): Collection

diff --git a/src/Sitemaps/Taxonomies/TermSitemapUrl.php b/src/Sitemaps/Taxonomies/TermSitemapUrl.php
@@ -67,7 +67,7 @@ public function site(): string
         return $this->term->locale();
     }
 
-    public function isCanonicalUrl(): bool
+    public function canonicalTypeIsCurrent(): bool
     {
         return $this->term->seo_canonical_type == 'current';
     }