🐛 Fix the keycloak pod name selector... #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it doesn't give the below error when there are other pods with more
than 1 container in the namespace
```
error executing jsonpath \"{.items[?(@.spec.containers[*].name==\\\"keycloak\\\")].metadata.name}\": can only compare one element at a time
```
maleck13
approved these changes
Apr 18, 2018
|
👀 |
pb82
approved these changes
Apr 18, 2018
There was a problem hiding this comment.
The change is fine, deploy and undeploy work. apb test fails but this is unrelated to this change: the apb is using the service instance id which is not defined during testing: https://github.com/aerogearcatalog/keycloak-apb/blob/master/roles/provision-keycloak-apb/templates/configmap.yml.j2#L9. Thats probably also the reason why it fails on Jenkins (which is also running apb test).
|
I was able to deploy and undeploy with this fix \0/! |
|
@david-martin In the UPS apb we use a special secret for testing that doesn't have the service instance id: https://github.com/aerogearcatalog/unifiedpush-apb/blob/master/roles/provision-unifiedpush-apb/tasks/provision-ups.yml#L143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it doesn't give the below error when there are other pods with more
than 1 container in the namespace
This fix should be OK as long as the keycloak pod doesn't have more than 1 container.
If that changes, we'll have to rethink labelling or something like that to allow easier selecting of the right pod
ping @secondsun @maleck13
related to #48