-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Haskell CI (fork) to latest GHC versions #2142
Conversation
andreasabel
commented
Oct 12, 2023
•
edited by MatthewDaggitt
Loading
edited by MatthewDaggitt
- Bump Haskell CI to latest minor GHC versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for porting it across! Apart from the one comment below, I think this looks good. @gallais any thoughts as you put most of the CI together?
@@ -6,11 +6,11 @@ | |||
# | |||
# haskell-ci regenerate | |||
# | |||
# For more information, see https://github.com/haskell-CI/haskell-ci | |||
# For more information, see https://github.com/andreasabel/haskell-ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My fork uses the ubuntu-20.04 image rather than the ubuntu-18.04 image which allows it to use the latest version of action/checkout.
And why do we need the latest version of action/checkout?
Not needed.
But you might get harassed by dependabot if you don't use it...
As discussed in the previous PR, unless there is a really convincing reason, I would really be happier continuing to use the main repo. In particular, we don't use dependabot yet, so I think the point is moot.
Any chance you could revert this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have created this workflow and I am maintaining it (inspect the history). Is there a problem if I maintain it my way?
If you must,
- please install https://github.com/haskell-CI/haskell-ci
- type
haskell-ci regenerate
- undo the changes it does to the triggers (
on
section in thehaskell-ci.yml
file); can be easily done using git tooling likemagit
or whatever - amend the commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did that in a parallel PR, so choose whatever you like better:
I'm more familiar with the |