Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ refactor ] rename ∣∣ to ∥, ∤∤ to ∦ throughout Algebra.Definitions.RawMagma and Algebra.Properties.*.Divisibility #2562

Merged
merged 2 commits into from
Jan 23, 2025
Merged

[ refactor ] rename ∣∣ to ∥, ∤∤ to ∦ throughout Algebra.Definitions.RawMagma and Algebra.Properties.*.Divisibility #2562

merged 2 commits into from
Jan 23, 2025
+176 −39

Conversation

jamesmckinna
Copy link
Contributor

Fixes #2551 .

@jamesmckinna jamesmckinna added this to the v2.3 milestone Jan 23, 2025
@Taneb
Copy link
Member

Taneb commented Jan 23, 2025 •
edited
Loading

How hard are these symbols to type in Agda input mode?

EDIT: I can check for myself, pretty easy, \|| and \||n

@jamesmckinna
Copy link
Contributor Author

jamesmckinna commented Jan 23, 2025 •
edited
Loading

How hard are these symbols to type in Agda input mode?

EDIT: I can check for myself, pretty easy, \|| and \||n

Yes, but perhaps that means that they should be documented in style-guide?

For belt-and-braces: I added a note to that effect.

@jamesmckinna jamesmckinna added this pull request to the merge queue Jan 23, 2025
Merged via the queue into agda:master with commit 0cccb39 Jan 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Taneb Taneb Taneb approved these changes

@gallais gallais gallais approved these changes

Assignees
No one assigned
Labels
deprecation refactoring
Projects
None yet
Milestone
v2.3
Development

Successfully merging this pull request may close these issues.

renaming ∤∤ --> ¬∣∣
3 participants
@jamesmckinna @Taneb @gallais