refactor: Centralize configuration management for URLs and client settings #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
XiangZhang-zx
commented
Jan 2, 2025
XiangZhang-zx
commented
- Add centralized configuration using YAML file
- Move hardcoded URLs and client settings to config
- Add configuration manager with environment variables support
- Update run_agent.py to use config values
## What Changed 1. **Local Tool Loading**: Added logic to check and load tools from the local directory first. 2. **Fixed NoneType Error**: Resolved the issue where the version was `None`, causing a `'NoneType' object has no attribute 'replace'` error. 3. **Improved Error Messages**: Enhanced error messages for better clarity and debugging. ## How It Works Now - **Local First**: The system first checks the local tools folder. - **Use Local Tool**: If a tool is found locally, it uses that version. - **Remote Fallback**: If not found locally, it downloads the tool. - **Version Handling**: Retrieves version from local `config.json` to ensure correct versioning. ## Testing - Tested with `math_agent` using local `wikipedia` tool. - Tested with `story_teller` agent. - Confirmed no NoneType errors occur.
## What Changed 1. **Local Tool Loading**: Added logic to check and load tools from the local directory first. 2. **Fixed NoneType Error**: Resolved the issue where the version was `None`, causing a `'NoneType' object has no attribute 'replace'` error. 3. **Improved Error Messages**: Enhanced error messages for better clarity and debugging. ## How It Works Now - **Local First**: The system first checks the local tools folder. - **Use Local Tool**: If a tool is found locally, it uses that version. - **Remote Fallback**: If not found locally, it downloads the tool. - **Version Handling**: Retrieves version from local `config.json` to ensure correct versioning.
## What Changed 1. **Local Tool Loading**: Added logic to check and load tools from the local directory first. 2. **Fixed NoneType Error**: Resolved the issue where the version was `None`, causing a `'NoneType' object has no attribute 'replace'` error. 3. **Improved Error Messages**: Enhanced error messages for better clarity and debugging. ## How It Works Now - **Local First**: The system first checks the local tools folder. - **Use Local Tool**: If a tool is found locally, it uses that version. - **Remote Fallback**: If not found locally, it downloads the tool. - **Version Handling**: Retrieves version from local `config.json` to ensure correct versioning.
## What Changed 1. **Local Tool Loading**: Added logic to check and load tools from the local directory first. 2. **Fixed NoneType Error**: Resolved the issue where the version was `None`, causing a `'NoneType' object has no attribute 'replace'` error. 3. **Improved Error Messages**: Enhanced error messages for better clarity and debugging. ## How It Works Now - **Local First**: The system first checks the local tools folder. - **Use Local Tool**: If a tool is found locally, it uses that version. - **Remote Fallback**: If not found locally, it downloads the tool. - **Version Handling**: Retrieves version from local `config.json` to ensure correct versioning.
- Add debug logs to track agent loading - Fix config handling in agent manager - Update seeact_demo_agent config format The code now: - Shows better error messages - Loads agents more reliably - Keeps full config when packaging"
## What's Changed - Added `--local_agent` flag to support loading agents from local filesystem - Added path validation for local agent loading - Simplified agent execution logic
This PR refactors the configuration management for Cerebrum by moving the URLs for the Agent and Tool Managers into a centralized configuration file (default.yaml). This change allows for easier management and customization of these URLs across different environments. Changes: Added agent_hub_url and tool_hub_url to default.yaml. 2. Updated AutoAgent and AutoTool classes to use URLs from the configuration file.
This reverts commit 1324ed1.
This reverts commit d7c864d.
|
Thank you for the suggestion! During the developer hour meeting, it was discussed to use 'yes' or 'no' for this argument, so I implemented it to support both 'yes/no' and 'true/false'. The GitBook documentation uses 'yes/no' as examples, but as shown in the code, 'true/false' are also supported. Let me know if this implementation works for you, or if any adjustments are needed! 
|
|
okay, this implementation also looks good, merged! |
dongyuanjushi
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.