feat: add query param on http RequestBuilder #150
Conversation
Update permissions table to reflect that users that have Developer role assigned to them can delete services. Closes: lightbend/kalix#12442
docs: avoid using support for features; don't mention coming soon
| @@ -36,6 +37,10 @@ public interface RequestBuilder<R> { | |||
|
|
|||
| RequestBuilder<R> withTimeout(Duration timeout); | |||
|
|
|||
| RequestBuilder<R> withQuery(String key, String value); | |||
|
|
|||
| RequestBuilder<R> withQuery(Query query); | |||
There was a problem hiding this comment.
I guess you added this to be able to add multiple parameters, maybe skip this in the public API for adding the Akka HTTP query type and have a addQueryParameter instead?
There was a problem hiding this comment.
Not sure if I get what you mean. What do you suggest addQueryParameter to look like? Wouldn't it be enough if we remove this method and rename the withQuery(String, String) into addQueryParameter?
There was a problem hiding this comment.
withNnn is expected to replace (and impl does) so subsequent calls drops the previous query. addNnnn is expected to add to existing so would allow adding multiple query parameters in a sequence:
httpClient.POST("/customer/" + id)
.addQueryParameter("one", "val1")
.addQueryParameter("two", "val2")
.invoceAsync()
Let me add it it to this pr. |
|
Shall we target |
Please change as needed, I have no idea about branches, versions and releases. There is no external demand, I wanted to use the api in a small project. |
|
I retargeted but that lead to conflict (and we have some stuff to merge from main, should be done separately, I can do that) |
|
Merging main into java-spi should sort the conflict as well (#151) |
|
Superseded by #157 |
Are tests needed here?