Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support asset transfers for decimal values over the safe number value #382

Open
wants to merge 1 commit into
base: test-algosdk-v3
Choose a base branch
from
Open

fix: support asset transfers for decimal values over the safe number value #382

wants to merge 1 commit into from

Conversation

neilcampbell
Copy link
Contributor

  • Support decimal asset transfer values over the limits of number
  • Refine asJson to convert to number where applicable
  • Fix zod bigInt schema usage

PatrickDinh
PatrickDinh approved these changes Jan 23, 2025
View reviewed changes
src/utils/as-json.ts
}

const defaultJsonValueReplacer = (_key: string, value: unknown) => {
if (typeof value === 'bigint') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not so sure about bigint can be serialised to either string or number ... I think I prefer it to be always string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickDinh PatrickDinh PatrickDinh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neilcampbell @PatrickDinh