fix: reinstate Liquid #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 74fdf73.
chore: prettier chore: fix test chore: prettier
HashMapsData2Value
force-pushed
the
fix/reinstate-liquid
branch
from
eca8a06 to
1e20116
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we failed to upgrade liquid-auth-use-wallet-client from AlgoSDK v2.9.0 to v3 in time, Doug had the Liquid wallet temporarily removed from inclusion into Use-Wallet v4.
This is the revert PR: TxnLab#337
This PR reverts the revert, while adjusting to changes to happened in the meantime (removal of networks).
Due to issues I encountered with pnpm on my computer, I switched to using my own fork of liquid-auth-use-wallet. On it I merged Algosdk v3.1 and pushed version 1.1.0 to NPM, and then used that as an import.
Turns out, the only thing I really had to do was update the test. The src code itself was already AlgoSDK v3 proof. A small worry I had had (and admittedly the reason for not just taking a quick look at this earlier) was that there would be an issue with the Android client demo app itself, but I found through testing with this branch that it worked as normal. I leave it to the reviewer to double check that however.
To test:
TODO: