feat: Applies PR review suggestions

allegro · Nov 2, 2023 · 76e25b3 · 76e25b3
1 parent 0086967
commit 76e25b3
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/shard.go b/shard.go
@@ -119,12 +119,14 @@ func (s *cacheShard) getValidWrapEntry(key string, hashedKey uint64) ([]byte, er
 
 func (s *cacheShard) contains(key string, hashedKey uint64) bool {
 	s.lock.RLock()
-	defer s.lock.RUnlock()
 	wrappedEntry, err := s.getWrappedEntry(hashedKey)
 	if err != nil {
+		s.lock.RUnlock()
 		return false
 	}
-	return key == readKeyFromEntry(wrappedEntry)
+	entryKey := readKeyFromEntry(wrappedEntry)
+	s.lock.RUnlock()
+	return key == entryKey
 }
 
 func (s *cacheShard) set(key string, hashedKey uint64, entry []byte) error {