Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pager duty integration #63

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

amanjpro
Copy link
Owner

PagerDuty here is just a proof of concept, the rest of the architecture is "client" agnostic. In theory adding a new client (alerting integration) is as simple as implementing AlertClient class.

This is the first step towards #29

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2020

Codecov Report

Merging #63 into master will decrease coverage by 7.39%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   96.68%   89.29%   -7.40%     
==========================================
  Files          19       21       +2     
  Lines         483      523      +40     
  Branches       19       27       +8     
==========================================
  Hits          467      467              
- Misses         16       56      +40     
Impacted Files Coverage Δ
src/main/scala/alerts/AlertActor.scala 0.00% <0.00%> (ø)
src/main/scala/alerts/PagerDutyClient.scala 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba580e2...c43f7d0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants